Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Tutorial: transfer-files (previsously #714)#774

Merged
daviddias merged 10 commits into
docs/example/transfer-filesfrom
docs/transfer-files-rebased
Mar 15, 2017
Merged

Tutorial: transfer-files (previsously #714)#774
daviddias merged 10 commits into
docs/example/transfer-filesfrom
docs/transfer-files-rebased

Conversation

@dignifiedquire
Copy link
Copy Markdown
Member

@dignifiedquire dignifiedquire commented Feb 24, 2017

Ref #714

daviddias
daviddias suggested changes Mar 6, 2017
View reviewed changes
Comment thread test/cli/bitswap.js
.then(() => {})
.catch(() => {})
setTimeout(done, 100)
setTimeout(done, 800)
Copy link
Copy Markdown
Member

@daviddias daviddias Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the need to increase the timeout?

Copy link
Copy Markdown
Member Author

@dignifiedquire dignifiedquire Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it randomly fails on CI due to things being slow

daviddias
daviddias suggested changes Mar 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@daviddias daviddias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the yarn.lock be another PR?

@dignifiedquire
Copy link
Copy Markdown
Member Author

dignifiedquire commented Mar 6, 2017

@diasdavid #772 but needs updating probably

@daviddias
Copy link
Copy Markdown
Member

daviddias commented Mar 6, 2017

@dignifiedquire got it, could you remove the yarn.lock from here then?

@victorb
Copy link
Copy Markdown
Member

victorb commented Mar 7, 2017

Worth to note is that this is not ready to be merged, the document at examples/transfer-files/README.md is still unfinished.

@daviddias daviddias changed the title Docs/transfer files rebased Example: transfer-files (previsously #714) Mar 7, 2017
@daviddias daviddias changed the title Example: transfer-files (previsously #714) Tutorial: transfer-files (previsously #714) Mar 7, 2017
@daviddias
Copy link
Copy Markdown
Member

daviddias commented Mar 7, 2017 •
edited
Loading

Thanks for bringing that up @victorbjelkholm, I've collected the missing action items, could you check if I missed any?

TODO

  • Take out the yarn.lock
  • Peers list have a comma between every peer that is not supposed to be there
  • Multiaddr input is too wide and goes outside the containing box
  • Refactor code + add valuable comments
  • Have .get actually work with just one file
  • Fix drag-and-drop not closing popup when ending up not dropping file in UI
  • Finish tutorial in readme.md

@daviddias daviddias mentioned this pull request Mar 7, 2017
Closed
@victorb
Copy link
Copy Markdown
Member

victorb commented Mar 9, 2017 •
edited
Loading

Multiaddr input is too wide and goes outside the containing box

Should not happen anymore, and I remember when Friedel demod multiplex by using this demo, it didn't happen anymore. But I'll verify to make sure.

Seems otherwise to capture everything that is missing (well, except that none of the CI is actually passing as well), thanks for that 👍

@daviddias daviddias added status/ready Ready to be worked and removed status/in-progress In progress labels Mar 9, 2017
@daviddias daviddias mentioned this pull request Mar 11, 2017
Closed
1 task
@daviddias daviddias changed the base branch from master to docs/example/transfer-files March 15, 2017 15:39
@daviddias daviddias merged commit 2c31523 into docs/example/transfer-files Mar 15, 2017
@daviddias daviddias deleted the docs/transfer-files-rebased branch March 15, 2017 15:39
@daviddias daviddias removed the status/ready Ready to be worked label Mar 15, 2017
daviddias pushed a commit that referenced this pull request Mar 17, 2017
@dignifiedquire @daviddias
Tutorial: transfer-files (previsously #714) (#774)
026c801 
* docs: transfer-files-example
daviddias pushed a commit that referenced this pull request Mar 21, 2017
@dignifiedquire @daviddias
docs: Tutorial: transfer-files (previsously #714) (#774)
f2ef1d9
daviddias pushed a commit that referenced this pull request Mar 21, 2017
@dignifiedquire @daviddias
docs: Tutorial: transfer-files (previsously #714) (#774)
3ee3acd
daviddias pushed a commit that referenced this pull request Mar 21, 2017
@dignifiedquire @daviddias
docs: Tutorial: transfer-files (previsously #714) (#774)
b2afbf4
daviddias pushed a commit that referenced this pull request Mar 21, 2017
@dignifiedquire @daviddias
docs: Tutorial: transfer-files (previsously #714) (#774)
8c243f1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@daviddias daviddias daviddias requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dignifiedquire @daviddias @victorb